Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

建议增加类似实例,比罗列参数更直观些 #890

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glkappe
Copy link
Contributor

@glkappe glkappe commented Apr 29, 2020

What problem does this PR solve?

How to contact you?

  • Email:
  • Telephone:
  • WeChat:
  • Others:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@glkappe
Copy link
Contributor Author

glkappe commented Dec 21, 2020

@kennytm 辛苦 review

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not quite sure about this addition. it is a usage string with no explanation (e.g. --db and --table doesn't work when using br backup full), unlike the command below it which is actually executable.

@@ -130,6 +130,11 @@ BR 命令包括备份,恢复两个操作,而备份,恢复又单独针对

### 6. 全库备份与恢复

```br backup (full | db | table) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```br backup (full | db | table) \
```
br backup (full | db | table) \

@@ -164,6 +169,11 @@ MySQL [br_test]> drop table br_table;

> 注意:恢复时候,每个 TiKV 节点都需要访问到所有备份文件,如果不是共享存储,需要手动复制所有备份文件到所有节点

```br restore (full | db | table) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```br restore (full | db | table) \
```
br restore (full | db | table) \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants