Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PurpleAir app to use the newest calculations #2862

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CoatedMoose
Copy link
Contributor

As of September 2024, PurpleAir has updated their (default) conversion/correction algorithms. This change updates to align the defaults used by this app with the defaults used by PurpleAir.

Different organizations define different "AQI" metrics so this change adds support for selecting your preferred metric. At this time, only the US EPA AQI is implemented.

Researchers have determined the underlying sensors are inaccurate in systematic ways, and have developed correction algorithms/formulas to address these issues. This change adds a mechanism for selecting a preferred correction algorithm. Only 3 of 8 correction algorithms are implemented.

@tidbyt
Copy link

tidbyt bot commented Nov 6, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of cache.star requires review
🟡 Original Author The original author (betterengineering) does not match the PR author (CoatedMoose)

@CoatedMoose CoatedMoose force-pushed the update-purple-air branch 4 times, most recently from 6697963 to 964bed1 Compare November 6, 2024 01:31
As of September 2024, PurpleAir has updated their (default)
conversion/correction algorithms. This change updates to align the
defaults used by this app with the defaults used by PurpleAir.

Different organizations define different "AQI" metrics so this change
adds support for selecting your preferred metric. At this time, only the
US EPA AQI is implemented.

Researchers have determined the underlying sensors are inaccurate in
systematic ways, and have developed correction algorithms/formulas to
address these issues. This change adds a mechanism for selecting a
preferred correction algorithm. Only 3 of 8 correction algorithms are
implemented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant