Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New App: Mondrian clock #2880

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

theredwillow
Copy link

@theredwillow theredwillow commented Nov 13, 2024

This app is a decorative clock face in the style of Piet Mondrian's De Stijl compositions.

A digital readout is available as a boolean configuration option in the schema. (I didn't know how to update the schema setting for the pixlet render.)

An explanation of how to read the clock is included in the README.md.

mondrianclock
The above clockface represents 5:38.

@tidbyt
Copy link

tidbyt bot commented Nov 13, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
🟡 App Dir File 'apps/mondrianclock/tutorial-images/01_01.jpg' is in apps/mondrianclock/tutorial-images
Modules Only safe modules, without side-effects, are loaded
Original Author The original author matches the PR author

tidbyt[bot]
tidbyt bot previously approved these changes Nov 13, 2024
@tidbyt-bot
Copy link

tidbyt-bot commented Nov 13, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@theredwillow
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

tidbyt[bot]
tidbyt bot previously approved these changes Nov 13, 2024
@theredwillow
Copy link
Author

It's giving a warning that app summaries should start with an uppercased character, but mine does ("M" for Mondrian). That appears to be a bug.

tidbyt[bot]
tidbyt bot previously approved these changes Nov 14, 2024
@theredwillow
Copy link
Author

I didn't see the pixlet create function until after I had manually created my app by following the precedent code. It doesn't mention on the page that you need to cd into your own app's folder.

I tried running that and taking the result from it to pass the buggy character checker. Seems to have worked.

@danielsitnik
Copy link
Contributor

Holy crap now that is a crazy clock!
I will need to read the manual to understand that 🤣

@theredwillow
Copy link
Author

theredwillow commented Nov 14, 2024

@danielsitnik I realize that reading a new way of reading a clock can be difficult. So I took some time to get useful webp's for a tutorial by hacking at the code with uncommitted changes so render could pick them up then added a thorough walk-through to my README.md with said images.

webp's are gitignored, but I noticed that the partyparrot app was allowed to be merged with a private gitignore to add their exception. Normally I wouldn't take the liberty of pull requesting a gitignore file, but I saw a precedent and thought this was probably fair.

I hope this helps you! Unfortunately, I don't know of a way to link this for the app store community. If you have any ideas, please let me know.

@jvivona
Copy link
Contributor

jvivona commented Nov 14, 2024

holy crap - I think my brain just broke, looking at that. A literal work of art.

you can render the sample image in GIF format via the pixlet render ( --gif) command line. Gifs are included in the community & can be committed.

@theredwillow
Copy link
Author

@jvivona I would love to render a gif of it looping through the whole thing, but...

  1. Gifs are limited to 15 seconds. Even if I could, it would either loop through so fast that it would barely make sense, or it would be like 12 minutes long. If I only included the 12 in this tutorial, then writing up the information would be difficult.
  2. This was engineered to be a clockface. Animating it to cycle would involve coding a very messy scaffold codework with.

@jvivona
Copy link
Contributor

jvivona commented Nov 14, 2024

sorry - i though the reason you were using webp was for the animation. just make them jpgs

@theredwillow
Copy link
Author

@jvivona unknown flag: --jpg Is this documented anywhere? How do I do that?

Also, it would be nice to include the twelve sample images as a gif for the app store (even if there's no room for explanation 😓). Is there a Starlark way to setTimeout? If so, I could wrap my render.Root into a function and loop over that... Much, much simpler than working with Animation.

@jvivona
Copy link
Contributor

jvivona commented Nov 14, 2024

pixlet render can't emit jpgs. take your webp files & convert them. this is what we use here. https://ezgif.com/webp-to-jpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants