Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate appID before encrypting #1072

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Validate appID before encrypting #1072

wants to merge 1 commit into from

Commits on May 7, 2024

  1. Validate appID before encrypting 

    We've all done it. It's too easy to use the wrong key to encrypt with, whether you use the app name, the folder name, or get the hyphens wrong. Cropped up again recently with tidbyt#1071.

If you're running pixlet encrypt from within the community repo, this will add a check that the provided key matches the ID field from some existing manifest. If not, you get an error.

Thought about @jmanske's suggestions but I don't think pixlet can assume there'll be exactly one manifest in the commit to check against. You might be updating multiple apps, in which case, which should you check? Or you might be fixing a bad encryption, and not have any local edits. App names are generally unique enough that I think this works.
    @dinosaursrarr
    dinosaursrarr committed May 7, 2024
    Configuration menu
    Copy the full SHA
    bd77d2e View commit details
    Browse the repository at this point in the history