Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACK-3392] Add OpenID sector for Abbott OAuth #817

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darinkrauss
Copy link
Contributor

Note: This implementation is a temporary placeholder to allow bootstrapping of the Abbott OAuth client workflow. Will need to migrate this to environment variables and add minimal authorization. For now, though, this is acceptable since it isn't revealing anything that is not already available in other locations (i.e. other public repos).

TODO: https://tidepool.atlassian.net/browse/BACK-3394

Copy link
Contributor

@ewollesen ewollesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of URLs / data to put in an env variable. I wonder if it shouldn't be a in a file, eventually that is.

As a temporary measure, it seems fine though.

@darinkrauss
Copy link
Contributor Author

Thanks. Where would we put the file? I'd like to put it in the infrastructure somewhere so it can be easily configured per environment. I'm probably missing something obvious.

Copy link
Contributor

@jh-bate jh-bate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants