-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Accu-Chek meters and pumps using Smart Pix (UPLOAD-685, UPLOAD-872) #1620
Draft
gniezen
wants to merge
58
commits into
master
Choose a base branch
from
smartpix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version supports only model 1 / gray SmartPix readers, reading insulin pumps. The reader must be attached and mounted (it shows as mass storage device) before reading is started. The XML part expects the document to be read with xml2js. The pump data parser understands only name of Spirit/Combo pump, but assuming that it is the reader that generates the report format, it should handle other pumps too. The parser understands data generated by Smart Pix 1 firmwares 3.01.03 and 3.05.01, but others should work too.
Sync with Tidepool master
This continues the support for model 1 / gray SmartPix reader, adding blood glucose measurement parsing. The meter data parser understands only name of Aviva Combo, but assuming that it is the reader that generates the report format, it should handle other meters too. The parser understands data generated by Smart Pix 1 firmwares 3.05.01, but others should work too.
To make it easier to read a externally stored report, make QUICKK_SINGLE_REPORT also accept a string as path to the report. This requires that the Driver.process accepts full path directly as argument instead of assuming it being a relative path.
makeFood() object was changed to have with_amount() in place of with_carbs(). - Fix few style etc issues. - Remove unneeded clockDriftOffset from both BG and IP parsers.
The implementation does not handle time changes (usually DST) and so might produce offset on time in one side of the jump.
- Use default export for the parser implementations' entry functions. - Shorten a too long line. - Disable few eslint rules for require('drivelist'), same pattern used elsewhere in the project.
…end-uploader into Sensotrend-smartpix-on-tp-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR as this work is currently blocked. Supersedes #1546 and #1432.