-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (android): global UnhandledRejection redirector to JSDialogError and uncaughtException handler #14182
base: master
Are you sure you want to change the base?
Conversation
Please check https://www.fromzerotoapp.com/extending-titanium-sdk/#link9 and rename the title according to it. This should be a |
Renamed! There something more I have to do? Need to resubmit the PR or not? |
@Informate no, you don't need to resubmit it. Please add the code example to the first post (edit it) so people know how to test it. |
Done |
GitHub Issues: #14177
Optional Description:
The unhandledRejection V8 event is unhandled by Titanium SDK at the moment, and the unhandledRejections event get silently lost.
This commit fixes the issue handling the V8 event and sending it from V8Runtime to the JS environment thorw Kroll with just few changes and modify.
The JS Error Dialog shows correctly and the Rejected Promises can now be cacthed by uncaughtException as an exception with type='Rejected Promise' (still not a Ti.App unhandledRejection event).
Code Example: