Skip to content

Make surv_reg() defunct and update NEWS #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make surv_reg() defunct and update NEWS #1294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7327c9
Make surv_reg() defunct and update NEWS
bjornkallerud Sep 19, 2025
8928da4
Apply suggestions from code review
topepo Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# parsnip (development version)

* `surv_reg()` is now defunct and will error if called. Please use `survival_reg()` instead (#1206).

# parsnip 1.3.3

* Bug fix in how tunable parameters were configured for brulee neural networks.
Expand Down
3 changes: 1 addition & 2 deletions R/surv_reg.R
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[air] reported by reviewdog 🐶

parsnip/R/surv_reg.R

Lines 32 to 46 in 8928da4

args <- list(
dist = enquo(dist)
)
new_model_spec(
"surv_reg",
args = args,
eng_args = NULL,
mode = mode,
user_specified_mode = !missing(mode),
method = NULL,
engine = engine,
user_specified_engine = !missing(engine)
)
}

Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@
#' @keywords internal
#' @export
surv_reg <- function(mode = "regression", engine = "survival", dist = NULL) {

lifecycle::deprecate_warn("0.1.6", "surv_reg()", "survival_reg()")
lifecycle::deprecate_stop("1.4.0", "surv_reg()", "survival_reg()")

args <- list(
dist = enquo(dist)
Expand Down
Loading