Skip to content

Upkeep 2025 06 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

MikeJohnPage
Copy link

closes #54

  • Feel free to reject the logo
  • We didn't implement all the tasks on the cleaning list as we reasoned some of them were not appropriate (e.g., align test and R file names)
  • We removed the call to downlit in the .Rmd, but feel free to revert

@krlmlr
Copy link
Member

krlmlr commented Jun 20, 2025

Thanks! The new way of rendering the README is to create a separate index.md to be consumed by pkgdown, see duckplyr and tibble for examples. I wouldn't mind a cynkrathis::use_*() function that helps with the setup.

I'd rather not spend time on hex logos, as much as I like them. I'd keep the logo in an issue for somebody else to decide.

@MikeJohnPage
Copy link
Author

@krlmlr in commit 2efaf15 I kept the call to:

x <- gsub(
    '(`vignette[(]"([^"]+)"[)]`)',
    "[\\1](https://blob.tidyverse.org/articles/\\2.html)",
    x
  )

Although there are no articles yet in the package, I thought it couldn't hurt to leave it there to both have symmetry with tibble and duckplyr, and also to future proof the process should an article be added.

@MikeJohnPage
Copy link
Author

The logo has now been moved to a separate PR as requested. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spring cleaning @ cynkra dev day 🧼
2 participants