Export table_path infrastructure #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1300 Includes some changes to make the interface a little nicer and to fix some issues I noticed while I was looking at this code with fresh eyes: * `table_name()` -> `table_path_name()` * `is_table_id()` requires characters and table_paths to be length 1 * Vectorise `table_path_components()` instead of `table_path_name()` * Make `table_path_components()` an S3 generic (as an escape hatch if needed)
mgirlich
reviewed
Feb 21, 2024
| table_path_components(table_path("`x.y`.`y.z`"), con), | ||
| list(c("x.y", "y.z")) | ||
| ) | ||
| }) |
There was a problem hiding this comment.
maybe add an expliciti test that table_path_components() is vectorised.
mgirlich
approved these changes
Feb 21, 2024
|
I don't see anything obvious missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1300
Includes some changes to make the interface a little nicer and to fix some issues I noticed while I was looking at this code with fresh eyes:
table_name()->table_path_name()is_table_id()requires characters and table_paths to be length 1table_path_components()instead oftable_path_name()table_path_components()an S3 generic (as an escape hatch if needed)@mgirlich this is a first pass based on what I need for bigrquery. Is there anything obviously missing?