Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comments to date translation to clarify non-SQL origins (months(), days() on Postgres + Snowflake) #1491

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fh-mthomson
Copy link
Contributor

I found myself confused while trying to trace back date translations in dbplyr to their non-SQL origins, specifically base vs. lubridate functions:

  • months() to lubridate, when the translations actually correspond to base::months()
  • days() to base R (actually corresponds to lubridate::days()

I've proposed minor comments to hopefully prevent this confusion for future folks referencing these backend-specific translations for days() and months() (only available for Postgres and Snowflake - the latter was mirrored from the former).

cc: @fh-afrachioni

@fh-mthomson fh-mthomson changed the title Mthomson/months not lubridate add comments to date translation to clarify non-SQL origins (months(), days() on Postgres + Snowflake) Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant