Skip to content

Commit

Permalink
Require data frame compatibility for setequal() (#6786)
Browse files Browse the repository at this point in the history
* Require data frame compatibility for setequal()

* Results

* This repo doesn't use fledge yet

* Move NEWS bullet

* Tweak tests to use snapshots

---------

Co-authored-by: DavisVaughan <[email protected]>
  • Loading branch information
krlmlr and DavisVaughan authored May 17, 2023
1 parent c48230c commit 16b472f
Show file tree
Hide file tree
Showing 8 changed files with 3,189 additions and 10,116 deletions.
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# dplyr (development version)

* `setequal()` now requires the input data frames to be compatible, similar to
the other set methods like `setdiff()` or `intersect()` (#6786).

# dplyr 1.1.2

* `count()` better documents that it has a `.drop` argument (#6820).
Expand Down
7 changes: 1 addition & 6 deletions R/sets.R
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,7 @@ setdiff.data.frame <- function(x, y, ...) {
#' @export
setequal.data.frame <- function(x, y, ...) {
check_dots_empty()
if (!is.data.frame(y)) {
abort("`y` must be a data frame.")
}
if (!isTRUE(is_compatible(x, y))) {
return(FALSE)
}
check_compatible(x, y)

cast <- vec_cast_common(x = x, y = y)
all(vec_in(cast$x, cast$y)) && all(vec_in(cast$y, cast$x))
Expand Down
170 changes: 39 additions & 131 deletions revdep/README.md
Original file line number Diff line number Diff line change
@@ -1,238 +1,146 @@
# Revdeps

## Failed to check (222)
## Failed to check (132)

|package |version |error |warning |note |
|:--------------------|:-------|:-----|:-------|:----|
|abstr |? | | | |
|accept |? | | | |
|ADAM |? | | | |
|afex |? | | | |
|AGread |? | | | |
|agridat |? | | | |
|AMARETTO |? | | | |
|amplican |? | | | |
|autoTS |? | | | |
|bangladesh |? | | | |
|bayesian |? | | | |
|bayesmodels |? | | | |
|bayesnec |? | | | |
|bayesplot |? | | | |
|BayesPostEst |? | | | |
|bayesrules |? | | | |
|NA |? | | | |
|bdl |? | | | |
|BiodiversityR |? | | | |
|blocs |? | | | |
|breathtestcore |? | | | |
|brendaDb |? | | | |
|broom.helpers |? | | | |
|broom.mixed |? | | | |
|BUSpaRse |? | | | |
|cancensus |? | | | |
|cattonum |? | | | |
|CCAMLRGIS |? | | | |
|ceRNAnetsim |? | | | |
|choroplethr |3.7.1 |1 | | |
|COMPASS |? | | | |
|cleanTS |0.1.1 |1 | | |
|CoordinateCleaner |2.0-20 |1 | | |
|CopernicusMarine |? | | | |
|CRE |? | | | |
|ctDNAtools |? | | | |
|NA |? | | | |
|ctsem |3.7.2 |1 | | |
|cubble |? | | | |
|cxr |? | | | |
|cyclestreets |? | | | |
|CytoML |? | | | |
|datawizard |? | | | |
|NA |? | | | |
|dbmss |? | | | |
|DeLorean |? | | | |
|DepecheR |? | | | |
|DiffBind |? | | | |
|diffman |? | | | |
|diffrprojects |? | | | |
|dycdtools |? | | | |
|dynamicSDM |? | | | |
|dynfrail |? | | | |
|edbuildmapr |? | | | |
|EFDR |? | | | |
|embed |? | | | |
|eflm |0.3.0 |1 | | |
|EnvExpInd |? | | | |
|epiphy |? | | | |
|escalation |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|eSDM |? | | | |
|ESTER |? | | | |
|evaluator |? | | | |
|expstudies |? | | | |
|fable.prophet |? | | | |
|finnts |? | | | |
|fipe |? | | | |
|foieGras |? | | | |
|fgdr |? | | | |
|NA |? | | | |
|NA |? | | | |
|FORTLS |? | | | |
|FRK |? | | | |
|fsr |? | | | |
|geocmeans |? | | | |
|GeodesiCL |1.0.0 |1 | | |
|ggchangepoint |? | | | |
|ggOceanMaps |? | | | |
|ggspatial |? | | | |
|ggstatsplot |? | | | |
|glottospace |? | | | |
|GREENeR |? | | | |
|gtfs2gps |? | | | |
|gumboot |? | | | |
|gwavr |? | | | |
|GWPR.light |? | | | |
|happign |? | | | |
|healthyR.ai |? | | | |
|healthyR.ts |? | | | |
|healthyverse |? | | | |
|himach |? | | | |
|historicalborrowlong |? | | | |
|HYPEtools |? | | | |
|hypsoLoop |? | | | |
|incidence2 |1.2.3 |1 | | |
|INSPECTumours |? | | | |
|NA |? | | | |
|intSDM |1.0.5 |1 | |1 |
|IRexamples |? | | | |
|IsoCorrectoR |? | | | |
|NA |? | | | |
|itsdm |? | | | |
|jpgrid |? | | | |
|loon.ggplot |? | | | |
|loon.shiny |? | | | |
|jpmesh |? | | | |
|NA |? | | | |
|MainExistingDatasets |? | | | |
|NA |? | | | |
|manydata |0.8.2 |1 | | |
|mapboxapi |? | | | |
|mapme.biodiversity |? | | | |
|mapping |? | | | |
|mapsapi |? | | | |
|mapscanner |? | | | |
|marginaleffects |? | | | |
|MazamaSpatialPlots |? | | | |
|merTools |? | | | |
|NA |? | | | |
|meteoland |? | | | |
|modeltime |? | | | |
|modeltime.ensemble |? | | | |
|modeltime.gluonts |? | | | |
|modeltime.h2o |? | | | |
|modeltime.resample |? | | | |
|NA |? | | | |
|NA |? | | | |
|motif |? | | | |
|mpower |? | | | |
|MSclassifR |? | | | |
|multibiasmeta |? | | | |
|naturaList |? | | | |
|ncdfgeom |? | | | |
|nhdplusTools |? | | | |
|nhdR |? | | | |
|nlmixr2est |2.1.3 |1 | | |
|nlmixr2extra |? | | | |
|nlmixr2plot |2.0.7 |1 | | |
|nlmixr2rpt |0.1.0 |1 | | |
|NA |? | | | |
|occCite |? | | | |
|occUncertain |0.1.0 |1 | | |
|oceanexplorer |? | | | |
|oceanis |? | | | |
|ohsome |? | | | |
|OpenLand |? | | | |
|ordbetareg |? | | | |
|palaeoSig |? | | | |
|panelr |? | | | |
|pct |? | | | |
|photosynthesis |? | | | |
|Platypus |? | | | |
|PoolTestR |? | | | |
|NA |? | | | |
|NA |? | | | |
|PopGenHelpR |? | | | |
|ppcSpatial |? | | | |
|prioriactions |? | | | |
|promotionImpact |? | | | |
|PSS.Health |0.6.1 |1 | | |
|rangeModelMetadata |? | | | |
|rbenvo |? | | | |
|RBesT |? | | | |
|rcontroll |? | | | |
|RCzechia |? | | | |
|rdss |? | | | |
|NA |? | | | |
|redist |? | | | |
|remap |? | | | |
|report |? | | | |
|rGhanaCensus |? | | | |
|rnaturalearth |? | | | |
|NA |? | | | |
|roads |? | | | |
|Robyn |? | | | |
|Rsagacmd |? | | | |
|rsinaica |? | | | |
|rstac |? | | | |
|rxode2 |2.0.11 |1 | | |
|rxode2et |2.0.9 |1 | | |
|saeSim |0.11.0 |1 | | |
|SAMtool |? | | | |
|sandwichr |? | | | |
|NA |? | | | |
|SDGdetector |2.7.1 |1 | | |
|SDLfilter |? | | | |
|sdmApp |? | | | |
|sf |? | | | |
|sfdep |? | | | |
|sfnetworks |? | | | |
|sftime |? | | | |
|ShellChron |? | | | |
|NA |? | | | |
|simodels |? | | | |
|simplevis |? | | | |
|sjPlot |? | | | |
|sjstats |? | | | |
|sknifedatar |? | | | |
|slendr |? | | | |
|sociome |2.1.0 |1 | |1 |
|SOMEnv |1.1.2 |1 | | |
|SpaDES.tools |? | | | |
|SPARTAAS |1.1.0 |1 | | |
|spatgeom |? | | | |
|SpatialEpi |1.2.8 |1 | | |
|SpatialKDE |? | | | |
|spatialrisk |? | | | |
|spatialsample |? | | | |
|spDates |? | | | |
|spectacles |0.5-3 |1 | | |
|spnaf |? | | | |
|spNetwork |? | | | |
|spqdep |? | | | |
|spsur |1.0.2.5 |1 | |1 |
|spup |? | | | |
|stars |? | | | |
|starsTileServer |? | | | |
|stats19 |? | | | |
|statsExpressions |? | | | |
|NA |? | | | |
|stplanr |? | | | |
|stppSim |? | | | |
|NA |? | | | |
|stxplore |? | | | |
|SUNGEO |? | | | |
|swfscAirDAS |0.2.3 |1 | | |
|SWTools |? | | | |
|NA |? | | | |
|telemac |? | | | |
|tidybayes |? | | | |
|tidyposterior |? | | | |
|tidySEM |? | | | |
|tilemaps |? | | | |
|timetk |? | | | |
|tipmap |? | | | |
|tmap |? | | | |
|NA |? | | | |
|trackdf |? | | | |
|trending |? | | | |
|TUFLOWR |? | | | |
|VancouvR |? | | | |
|vivid |? | | | |
|wallace |? | | | |
|waterquality |? | | | |
|NA |? | | | |
|waves |0.2.4 |1 | | |
|wdpar |? | | | |
|wearables |0.8.1 |1 | | |
|webSDM |? | | | |
|xpose.nlmixr2 |0.4.0 |1 | | |
|NA |? | | | |
|zipcodeR |0.3.5 |1 | | |
|zonebuilder |? | | | |

## New problems (4)
## New problems (2)

|package |version |error |warning |note |
|:-----------|:-------|:------|:-------|:----|
|[dm](problems.md#dm)|1.0.4 |__+1__ | | |
|package |version |error |warning |note |
|:----------|:-------|:------|:-------|:----|
|[exuber](problems.md#exuber)|1.0.1 |__+1__ | |1 |
|[missCompare](problems.md#misscompare)|1.0.3 |__+1__ | | |
|[rapbase](problems.md#rapbase)|1.24.0 |__+1__ | | |
|[modelplotr](problems.md#modelplotr)|1.1.0 | |__+1__ | |

Loading

0 comments on commit 16b472f

Please sign in to comment.