Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos plus minor tweaks #6875

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Fix typos plus minor tweaks #6875

merged 2 commits into from
Aug 23, 2023

Conversation

salim-b
Copy link
Contributor

@salim-b salim-b commented Jun 29, 2023

No description provided.

Copy link
Member

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The "be able to" might seem redundant, and we need to update the .Rd files?

@salim-b
Copy link
Contributor Author

salim-b commented Aug 23, 2023

The "be able to" might seem redundant

I added this because it's optional that the user supplies a tidyselect specification when wrapping the function argument in double braces ({{ arg }}); arg could still be a "regular" symbol or vector, right?

and we need to update the .Rd files

You want me to add this to this PR? Or do you use some GH action for this anyways?

@krlmlr
Copy link
Member

krlmlr commented Aug 23, 2023

I'm not sure, I'm not a native speaker.

There are other PRs without .Rd updates, it's fine.

@DavisVaughan DavisVaughan merged commit 75a6b25 into tidyverse:main Aug 23, 2023
4 checks passed
@DavisVaughan
Copy link
Member

Thanks!

@salim-b salim-b deleted the patch-1 branch August 23, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants