Fix Claude no-arg tool calling in streaming mode #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
force-pushed
the
claude-no-args
branch
from
57b2512 to
ac84fc7
Compare
hadley
approved these changes
Dec 18, 2024
| @@ -52,7 +52,7 @@ test_tools_simple <- function(chat_fun) { | |||
| chat <- chat_fun(system_prompt = "Be very terse, not even punctuation.") | |||
| chat$register_tool(tool(function() "2024-01-01", "Return the current date")) | |||
|
|
|||
| result <- chat$chat("What's the current date in YMD format?") | |||
| result <- chat$chat("What's the current date in YMD format?", echo = TRUE) | |||
There was a problem hiding this comment.
Yes--this turns on streaming, which makes the test fail without this fix and pass with this fix.
I know this also makes Gemini fail, until we merge the other PR.
There was a problem hiding this comment.
Ok, gotcha. Let's merge and then fix gemini ASAP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #228