Add viewer-based credential support for Azure, Databricks & Snowflake #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume we shouldn't merge this until after I do the patch release on Monday? |
|
If you feel like the design is good I can make a push to get |
|
The design seems solid to me, and it would be nice to get all the auth stuff into the same release. Why don't you have a go at submitting connectcreds to CRAN, and assuming that goes well, I'll submit ellmer afterwards. |
atheriel
force-pushed
the
viewer-based-credentials-v5
branch
from
b51c47c to
a003aa2
Compare
|
connectcreds is now on CRAN. 🎉 |
hadley
approved these changes
Feb 2, 2025
R/provider-azure.R
Outdated
|
|
||
| # Detect viewer-based credentials from Posit Connect. | ||
| if ( | ||
| is_installed("connectcreds") && |
There was a problem hiding this comment.
Maybe wrap this in a ellmer utility function? (I really don’t like the line breaks)
This commit brings support for Posit Connect's "viewer-based credentials" feature [0] to Azure, Databricks, and Snowflake chatbots. Checks for viewer-based credentials are designed to fall back gracefully to existing authentication methods. This is intended to allow users to -- for example -- develop and test a Shiny app that uses Azure, Databricks, or Snowflake credentials in desktop Positron/RStudio or Posit Workbench and deploy it with no code changes to Connect. Most of the actual work is outsourced to a new shared package, `connectcreds` [1]. In this latest version, the API of that package has been dramatically simplified, meaning the changes to `ellmer` are far less invasive than in previous patches. Unit tests are included. They make use of the mocking features of the `connectcreds` package to emulate a Connect environment. [0]: https://docs.posit.co/connect/user/oauth-integrations/ [1]: https://github.com/posit-dev/connectcreds/ Signed-off-by: Aaron Jacobs <[email protected]>
atheriel
force-pushed
the
viewer-based-credentials-v5
branch
from
a003aa2 to
82559dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit brings support for Posit Connect's "viewer-based credentials" feature to Azure, Databricks, and Snowflake chatbots.
Checks for viewer-based credentials are designed to fall back gracefully to existing authentication methods. This is intended to allow users to -- for example -- develop and test a Shiny app that uses Azure, Databricks, or Snowflake credentials in desktop Positron/RStudio or Posit Workbench and deploy it with no code changes to Connect.
Most of the actual work is outsourced to a new shared package,
connectcreds. In this latest version, the API of that package has been dramatically simplified, meaning the changes toellmerare far less invasive than in previous patches.Unit tests are included. They make use of the mocking features of the
connectcredspackage to emulate a Connect environment.Supersedes #183.