Allow decomposition model response check to tolerate missing values

Resolves #388
tidyverts · Nov 11, 2023 · 261b695 · 261b695
1 parent dfc4011
commit 261b695
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/R/model_decomposition.R b/R/model_decomposition.R
@@ -67,7 +67,11 @@ Please specify an appropriate model for these components",
 
   model <- reduce(c(mdls, mdls_default), `+`)
 
-  if(!isTRUE(all.equal(response(model)[[".response"]], .data[[measured_vars(.data)]]))){
+  all_match <- function(x, y) {
+    non_missing <- complete.cases(x, y)
+    isTRUE(all.equal(x[non_missing], y[non_missing]))
+  }
+  if(!all_match(response(model)[[".response"]], .data[[measured_vars(.data)]])) {
     abort(
 "The models specified do not combine to give the correct response.
 Please check that you have specified the decomposition models appropriately.")