Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decomposition_model fail when using classical_decomposition #388

Closed
robjhyndman opened this issue Nov 10, 2023 · 1 comment
Closed

decomposition_model fail when using classical_decomposition #388

robjhyndman opened this issue Nov 10, 2023 · 1 comment

Comments

@robjhyndman
Copy link
Member

MRE:

as_tsibble(USAccDeaths) |> 
  model(decomposition_model(
  classical_decomposition(value, type = "additive"),
  NAIVE(season_adjust)
))
@mitchelloharawild
Copy link
Member

Also requires latest feasts fix in tidyverts/feasts@2823121
The specification of the seasonally adjusted variable's structure wasn't appropriate - correct, but not suitable for the software design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robjhyndman @mitchelloharawild