Fix difference() giving extra NA values for short vectors

Resolves #310
tidyverts · May 12, 2024 · 12f95b8 · 12f95b8
1 parent 9e0057e
commit 12f95b8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,5 @@
+* Fix `difference()` giving extra NA values when the time series is shorter than the lag length. (#310, @mitchelloharawild)
+
 # tsibble 1.1.4
 
 * Fixed `vec_ptype2()` for `yearweek` and `yearquarter` for non-default week start. (#299)

diff --git a/R/time-wise.R b/R/time-wise.R
@@ -43,5 +43,5 @@ difference <- function(x, lag = 1, differences = 1, default = NA,
 
 diff_impl <- function(x, lag = 1, differences = 1, default = NA) {
   diff_x <- diff(x, lag = lag, differences = differences)
-  vec_c(vec_rep(default, lag * differences), diff_x)
+  vec_c(vec_rep(default, pmin(vec_size(x), lag * differences)), diff_x)
 }
diff --git a/tests/testthat/test-timewise.R b/tests/testthat/test-timewise.R
@@ -21,3 +21,8 @@ test_that("difference() with `order_by`", {
   #   right <- mutate(scrambled, diff = difference(value, order_by = year)), msg)
   # expect_equal(sort(right$diff, na.last = FALSE), difference(tsbl$value))
 })
+
+
+test_that("difference() with short time series (#310)", {
+  expect_length(difference(1, differences = 3), 1L)
+})