Skip to content

Commit

Permalink
removed is.tsibble() and did revcheck
Browse files Browse the repository at this point in the history
  • Loading branch information
@earowang
earowang committed Jan 24, 2024
1 parent 3d907de commit b594a20
Show file tree
Hide file tree
Showing 6 changed files with 188 additions and 55 deletions.
1 change: 0 additions & 1 deletion NAMESPACE
View file
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,6 @@ export(index_var)
export(intersect)
export(interval)
export(interval_pull)
export(is.tsibble)
export(is_53weeks)
export(is_duplicated)
export(is_grouped_ts)
Expand Down
18 changes: 2 additions & 16 deletions R/as-tsibble.R
View file
Original file line number Diff line number Diff line change
@@ -1,17 +1,3 @@
#' Deprecated functions
#'
#' @description
#' * `is.tsibble()` \lifecycle{defunct}
#'
#' @param x Other objects.
#'
#' @rdname deprecated
#' @export
#' @keywords internal
is.tsibble <- function(x) {
lifecycle::deprecate_stop("0.8.4", "is.tsibble()", "is_tsibble()")
}

globalVariables(c(".rows"))

setOldClass(c("tbl_ts", "tbl_df", "tbl", "data.frame"))
Expand Down Expand Up @@ -609,14 +595,14 @@ assert_key_data <- function(x) {
#' @export
rbind.tbl_ts <- function(...) {
abort(c(
"Not supported for tsibble.",
"Not supported for tsibble.",
i = "Please use `dplyr::bind_rows()` instead."))
}

#' @keywords internal
#' @export
cbind.tbl_ts <- function(...) {
abort(c(
"Not supported for tsibble.",
"Not supported for tsibble.",
i = "Please use `dplyr::bind_cols()` instead."))
}
17 changes: 0 additions & 17 deletions man/deprecated.Rd
View file

This file was deleted.

46 changes: 28 additions & 18 deletions revdep/README.md
View file
Original file line number Diff line number Diff line change
@@ -1,26 +1,36 @@
# Platform

|field |value |
|:--------|:------------------------------------|
|version |R version 4.2.0 (2022-04-22) |
|os |macOS Monterey 12.6 |
|system |x86_64, darwin17.0 |
|ui |RStudio |
|language |(EN) |
|collate |en_AU.UTF-8 |
|ctype |en_AU.UTF-8 |
|tz |Australia/Sydney |
|date |2022-10-09 |
|rstudio |2021.09.0+351 Ghost Orchid (desktop) |
|pandoc |2.16.1 @ /usr/local/bin/pandoc |
|field |value |
|:--------|:-----------------------------------|
|version |R version 4.3.0 (2023-04-21) |
|os |macOS 14.2.1 |
|system |aarch64, darwin20 |
|ui |RStudio |
|language |(EN) |
|collate |en_US.UTF-8 |
|ctype |en_US.UTF-8 |
|tz |Australia/Sydney |
|date |2024-01-24 |
|rstudio |2023.12.0+369 Ocean Storm (desktop) |
|pandoc |3.1.11.1 @ /opt/homebrew/bin/pandoc |

# Dependencies

|package |old |new |Δ |
|:-------|:-----|:------|:--|
|tsibble |1.1.2 |1.1.3 |* |
|dplyr |NA |1.0.10 |* |
|purrr |NA |0.3.5 |* |
|package |old |new |Δ |
|:----------|:-----|:--------|:--|
|tsibble |1.1.3 |1.1.4 |* |
|BH |NA |1.84.0-0 |* |
|dplyr |NA |1.1.4 |* |
|lubridate |NA |1.9.3 |* |
|Rcpp |NA |1.0.12 |* |
|timechange |NA |0.3.0 |* |

# Revdeps

## Failed to check (2)

|package |version |error |warning |note |
|:-------|:-------|:-----|:-------|:----|
|fable |0.3.3 |1 | | |
|UComp |4.0.2 |1 | | |

10 changes: 8 additions & 2 deletions revdep/cran.md
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
## revdepcheck results

We checked 27 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
We checked 35 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 0 packages
* We failed to check 2 packages

Issues with CRAN packages are summarised below.

### Failed to check

* fable (NA)
* UComp (NA)
151 changes: 150 additions & 1 deletion revdep/failures.md
View file
Original file line number Diff line number Diff line change
@@ -1 +1,150 @@
*Wow, no problems at all. :)*
# fable

<details>

* Version: 0.3.3
* GitHub: https://github.com/tidyverts/fable
* Source code: https://github.com/cran/fable
* Date/Publication: 2023-03-22 16:00:02 UTC
* Number of recursive dependencies: 111

Run `revdepcheck::revdep_details(, "fable")` for more info

</details>

## In both

* checking whether package ‘fable’ can be installed ... ERROR
```
Installation failed.
See ‘/Users/earo/Documents/rpkgs/tsibble/revdep/checks.noindex/fable/new/fable.Rcheck/00install.out’ for details.
```
## Installation
### Devel
```
* installing *source* package ‘fable’ ...
** package ‘fable’ successfully unpacked and MD5 sums checked
** using staged installation
** libs
using C compiler: ‘Apple clang version 15.0.0 (clang-1500.1.0.2.5)’
using C++ compiler: ‘Apple clang version 15.0.0 (clang-1500.1.0.2.5)’
using SDK: ‘MacOSX14.2.sdk’
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I'/Users/earo/Documents/rpkgs/tsibble/revdep/library.noindex/tsibble/new/Rcpp/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c etsTargetFunction.cpp -o etsTargetFunction.o
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I'/Users/earo/Documents/rpkgs/tsibble/revdep/library.noindex/tsibble/new/Rcpp/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c etsTargetFunctionWrapper.cpp -o etsTargetFunctionWrapper.o
clang -arch arm64 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I'/Users/earo/Documents/rpkgs/tsibble/revdep/library.noindex/tsibble/new/Rcpp/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c etscalc.c -o etscalc.o
...
clang++ -arch arm64 -std=gnu++17 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/Library/Frameworks/R.framework/Resources/lib -L/opt/R/arm64/lib -o fable.so etsTargetFunction.o etsTargetFunctionWrapper.o etscalc.o registerDynamicSymbol.o -L/Library/Frameworks/R.framework/Resources/lib -lRlapack -L/Library/Frameworks/R.framework/Resources/lib -lRblas -L/opt/gfortran/lib/gcc/aarch64-apple-darwin20.0/12.2.0 -L/opt/gfortran/lib -lgfortran -lemutls_w -lquadmath -F/Library/Frameworks/R.framework/.. -framework R -Wl,-framework -Wl,CoreFoundation
ld: warning: -single_module is obsolete
ld: warning: -multiply_defined is obsolete
ld: warning: search path '/opt/gfortran/lib/gcc/aarch64-apple-darwin20.0/12.2.0' not found
ld: warning: search path '/opt/gfortran/lib' not found
ld: library 'gfortran' not found
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [fable.so] Error 1
ERROR: compilation failed for package ‘fable’
* removing ‘/Users/earo/Documents/rpkgs/tsibble/revdep/checks.noindex/fable/new/fable.Rcheck/fable’


```
### CRAN
```
* installing *source* package ‘fable’ ...
** package ‘fable’ successfully unpacked and MD5 sums checked
** using staged installation
** libs
using C compiler: ‘Apple clang version 15.0.0 (clang-1500.1.0.2.5)’
using C++ compiler: ‘Apple clang version 15.0.0 (clang-1500.1.0.2.5)’
using SDK: ‘MacOSX14.2.sdk’
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I'/Users/earo/Documents/rpkgs/tsibble/revdep/library.noindex/fable/Rcpp/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c etsTargetFunction.cpp -o etsTargetFunction.o
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I'/Users/earo/Documents/rpkgs/tsibble/revdep/library.noindex/fable/Rcpp/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c etsTargetFunctionWrapper.cpp -o etsTargetFunctionWrapper.o
clang -arch arm64 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I'/Users/earo/Documents/rpkgs/tsibble/revdep/library.noindex/fable/Rcpp/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c etscalc.c -o etscalc.o
...
clang++ -arch arm64 -std=gnu++17 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/Library/Frameworks/R.framework/Resources/lib -L/opt/R/arm64/lib -o fable.so etsTargetFunction.o etsTargetFunctionWrapper.o etscalc.o registerDynamicSymbol.o -L/Library/Frameworks/R.framework/Resources/lib -lRlapack -L/Library/Frameworks/R.framework/Resources/lib -lRblas -L/opt/gfortran/lib/gcc/aarch64-apple-darwin20.0/12.2.0 -L/opt/gfortran/lib -lgfortran -lemutls_w -lquadmath -F/Library/Frameworks/R.framework/.. -framework R -Wl,-framework -Wl,CoreFoundation
ld: warning: -single_module is obsolete
ld: warning: -multiply_defined is obsolete
ld: warning: search path '/opt/gfortran/lib/gcc/aarch64-apple-darwin20.0/12.2.0' not found
ld: warning: search path '/opt/gfortran/lib' not found
ld: library 'gfortran' not found
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [fable.so] Error 1
ERROR: compilation failed for package ‘fable’
* removing ‘/Users/earo/Documents/rpkgs/tsibble/revdep/checks.noindex/fable/old/fable.Rcheck/fable’


```
# UComp
<details>
* Version: 4.0.2
* GitHub: NA
* Source code: https://github.com/cran/UComp
* Date/Publication: 2023-05-20 07:30:09 UTC
* Number of recursive dependencies: 83
Run `revdepcheck::revdep_details(, "UComp")` for more info
</details>
## In both
* checking whether package ‘UComp’ can be installed ... ERROR
```
Installation failed.
See ‘/Users/earo/Documents/rpkgs/tsibble/revdep/checks.noindex/UComp/new/UComp.Rcheck/00install.out’ for details.
```
## Installation
### Devel
```
* installing *source* package ‘UComp’ ...
** package ‘UComp’ successfully unpacked and MD5 sums checked
** using staged installation
** libs
using C++ compiler: ‘Apple clang version 15.0.0 (clang-1500.1.0.2.5)’
using SDK: ‘MacOSX14.2.sdk’
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I'/Users/earo/Documents/rpkgs/tsibble/revdep/library.noindex/tsibble/new/Rcpp/include' -I'/Users/earo/Documents/rpkgs/tsibble/revdep/library.noindex/UComp/RcppArmadillo/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c RcppExports.cpp -o RcppExports.o
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I'/Users/earo/Documents/rpkgs/tsibble/revdep/library.noindex/tsibble/new/Rcpp/include' -I'/Users/earo/Documents/rpkgs/tsibble/revdep/library.noindex/UComp/RcppArmadillo/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c UCompC.cpp -o UCompC.o
clang++ -arch arm64 -std=gnu++17 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/Library/Frameworks/R.framework/Resources/lib -L/opt/R/arm64/lib -o UComp.so RcppExports.o UCompC.o -L/Library/Frameworks/R.framework/Resources/lib -lRlapack -L/Library/Frameworks/R.framework/Resources/lib -lRblas -L/opt/gfortran/lib/gcc/aarch64-apple-darwin20.0/12.2.0 -L/opt/gfortran/lib -lgfortran -lemutls_w -lquadmath -F/Library/Frameworks/R.framework/.. -framework R -Wl,-framework -Wl,CoreFoundation
ld: warning: -single_module is obsolete
ld: warning: -multiply_defined is obsolete
ld: warning: search path '/opt/gfortran/lib/gcc/aarch64-apple-darwin20.0/12.2.0' not found
ld: warning: search path '/opt/gfortran/lib' not found
ld: library 'gfortran' not found
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [UComp.so] Error 1
ERROR: compilation failed for package ‘UComp’
* removing ‘/Users/earo/Documents/rpkgs/tsibble/revdep/checks.noindex/UComp/new/UComp.Rcheck/UComp’


```
### CRAN
```
* installing *source* package ‘UComp’ ...
** package ‘UComp’ successfully unpacked and MD5 sums checked
** using staged installation
** libs
using C++ compiler: ‘Apple clang version 15.0.0 (clang-1500.1.0.2.5)’
using SDK: ‘MacOSX14.2.sdk’
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I'/Users/earo/Documents/rpkgs/tsibble/revdep/library.noindex/UComp/Rcpp/include' -I'/Users/earo/Documents/rpkgs/tsibble/revdep/library.noindex/UComp/RcppArmadillo/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c RcppExports.cpp -o RcppExports.o
clang++ -arch arm64 -std=gnu++17 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I'/Users/earo/Documents/rpkgs/tsibble/revdep/library.noindex/UComp/Rcpp/include' -I'/Users/earo/Documents/rpkgs/tsibble/revdep/library.noindex/UComp/RcppArmadillo/include' -I/opt/R/arm64/include -fPIC -falign-functions=64 -Wall -g -O2 -c UCompC.cpp -o UCompC.o
clang++ -arch arm64 -std=gnu++17 -dynamiclib -Wl,-headerpad_max_install_names -undefined dynamic_lookup -single_module -multiply_defined suppress -L/Library/Frameworks/R.framework/Resources/lib -L/opt/R/arm64/lib -o UComp.so RcppExports.o UCompC.o -L/Library/Frameworks/R.framework/Resources/lib -lRlapack -L/Library/Frameworks/R.framework/Resources/lib -lRblas -L/opt/gfortran/lib/gcc/aarch64-apple-darwin20.0/12.2.0 -L/opt/gfortran/lib -lgfortran -lemutls_w -lquadmath -F/Library/Frameworks/R.framework/.. -framework R -Wl,-framework -Wl,CoreFoundation
ld: warning: -single_module is obsolete
ld: warning: -multiply_defined is obsolete
ld: warning: search path '/opt/gfortran/lib/gcc/aarch64-apple-darwin20.0/12.2.0' not found
ld: warning: search path '/opt/gfortran/lib' not found
ld: library 'gfortran' not found
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [UComp.so] Error 1
ERROR: compilation failed for package ‘UComp’
* removing ‘/Users/earo/Documents/rpkgs/tsibble/revdep/checks.noindex/UComp/old/UComp.Rcheck/UComp’


```

0 comments on commit b594a20

Please sign in to comment.