Feature/smooth ndt map update #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anhnv3991
commented
Feb 13, 2024
anhnv3991
commented
- Add copy and move constructors/assignment operators to NDT and voxel grid covariance
Signed-off-by: anhnv3991 <[email protected]>
Signed-off-by: anhnv3991 <[email protected]>
Signed-off-by: anhnv3991 <[email protected]>
|
Thank you for the pull request! |
4 tasks
include/multigrid_pclomp/multi_voxel_grid_covariance_omp_impl.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: anhnv3991 <[email protected]>
* Added pre-commit Signed-off-by: Shintaro Sakoda <[email protected]> * Test commit to confirm if pre-commit working Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix * Added types to build.yml Signed-off-by: Shintaro Sakoda <[email protected]> * Added types test Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix * Added workflow_run Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix * Removed workflow_run Signed-off-by: Shintaro Sakoda <[email protected]> * Removed spaces Signed-off-by: Shintaro Sakoda <[email protected]> * Applied formatter Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix * Added clang-format --version Signed-off-by: Shintaro Sakoda <[email protected]> * Updated version of mirrors-clang-format Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix * Removed incorrect version display Signed-off-by: Shintaro Sakoda <[email protected]> --------- Signed-off-by: Shintaro Sakoda <[email protected]> Co-authored-by: SakodaShintaro <[email protected]>
|
@SakodaShintaro I just rebase the tier4/main branch, so could you please check again? |
SakodaShintaro
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
I don't know why, but once the auto format is committed in pre-commit, the build check results are not visible in this pull request.
The build check itself is being executed, and everything is OK.
https://github.com/tier4/ndt_omp/actions/runs/7970490513
I also checked the operation of logging_simulator again using Autoware and it worked properly. 💯
|
@SakodaShintaro Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.