Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: performance tuning for eve #77

Merged

Conversation

kimurariku
Copy link

@kimurariku kimurariku commented Jan 9, 2025

PR Type

  • Improvement

Related Links

Internal Link

Description

The perpose of this PR is to incorporate changes for improving memory usage of NDT Scan Matcher.

Review Procedure

Confirmed that this commit is in the diff between chore/performance_tuning_for_eve and performance_tuning_for_eve.
The following image shows the output from executing the command git diff chore/performance_tuning_for_eve performance_tuning_for_eve >> diff_result.txt.
image
diff_result.txt

this commit has been merged in this PR

image
106cbaa -> 33d91e2
6033ae1 -> 10c4912
These commit has been captured by cherry-pick.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code follows [coding guidelines][coding-guidelines]
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows [coding guidelines][coding-guidelines]
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes
  • (When added something to .repos) Check if proper access rights are set.
    You can check the latest permission setting status of each repository [here][github-repository-status].
    If the repository permissions are insufficient, you need to add the permissions according to [this][repository-permission-setting-flow].

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write [release notes][release-notes]

CI Checks

  • vcs import: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@kimurariku kimurariku requested a review from asa-naki January 9, 2025 04:36
Copy link

@asa-naki asa-naki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the change is only for #71 and I approve it.

@kimurariku kimurariku merged commit c03ff7c into feat/x1eve/reduce_memory_usage Jan 9, 2025
8 checks passed
@kimurariku kimurariku deleted the chore/performance_tuning_for_eve branch January 9, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants