Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(voxel_grid_covariance_omp): remove cin in radius search (#69) #79

Conversation

kimurariku
Copy link

PR Type

  • Improvement

Related Links

Internal Link

Description

The purpose of this PR is to ensure std:cin will not be called every time running radiusSearch in ndt_omp

Review Procedure

Contents already discussed in this PR

This PR has merged 5972635 from x1eve/beta/v0.0.0
The commit e0901d9 of this PR is converted to 5972635 when it was merged.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code follows [coding guidelines][coding-guidelines]
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows [coding guidelines][coding-guidelines]
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes
  • (When added something to .repos) Check if proper access rights are set.
    You can check the latest permission setting status of each repository [here][github-repository-status].
    If the repository permissions are insufficient, you need to add the permissions according to [this][repository-permission-setting-flow].

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write [release notes][release-notes]

CI Checks

  • vcs import: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Sorry, something went wrong.

@kimurariku kimurariku requested a review from asa-naki January 9, 2025 11:01
@kimurariku kimurariku closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants