fix(nebula_ros): remove calibration file argument from robosense launch

[mebasoglu]

PR Type

• Bug Fix

Related Links

Fixes: #115

Description

Since Robosense lidars provides calibration data via DIFOP packets, we don't require a calibration file. Every time the driver is started, calibration data is parsed from incoming DIFOP packets.

The calibration file argument was added during development process and removed after further developments. Currently, Robosense driver doesn't use them.

Review Procedure

The Robosense launch file should make the driver launch without errors.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5061cd) 6.54% compared to head (6fe1fc3) 5.82%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff            @@
##            main    #116      +/-   ##
========================================
- Coverage   6.54%   5.82%   -0.72%     
========================================
  Files        136      28     -108     
  Lines      10956    4049    -6907     
  Branches     859     463     -396     
========================================
- Hits         717     236     -481     
+ Misses      9663    3401    -6262     
+ Partials     576     412     -164     

Flag	Coverage Δ
differential	5.82% <ø> (?)
total	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[knzo25]

@mebasoglu
Max is expected to rejoin us in March, so is it ok if I review approve it?

[mebasoglu]

Hello @knzo25 , it is okay. Thank you for the information.

[knzo25]

LGTM !