Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hesai): add TSN settings for Hesai sensors (OT128) #125

Merged
merged 5 commits into from
Mar 14, 2024

Conversation

drwnz
Copy link
Collaborator

@drwnz drwnz commented Mar 11, 2024

PR Type

  • New Feature

Related Links

Description

Hesai OT128 has different handling of PTP settings, as it only allows 802.1AS Automotive and allows setting of switch type (TSN or not). This in turn changes PTP from the default P2P to use E2E when the switch type is changed to non-TSN.

Review Procedure

  • Connect OT128 sensor
  • Configure sensor with 802.1AS Automotive via launchfile, and set ptp_switch_type to TSN or NON_TSN
  • Confirm PTP operation, and also check that the delay measurement mechanism is correctly configured

Remarks

ToDo:

  • Tests to clear build and test if required

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@drwnz drwnz requested a review from mojomex March 11, 2024 08:40
@drwnz drwnz self-assigned this Mar 11, 2024
Copy link
Collaborator

@mojomex mojomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment above, the code looks good! Thank you.
I'll try and test it with a real sensor tomorrow.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 8.33%. Comparing base (45c01cf) to head (05990d1).

Files Patch % Lines
.../nebula_hesai_hw_interfaces/hesai_hw_interface.cpp 0.00% 16 Missing ⚠️
...a_ros/src/hesai/hesai_hw_interface_ros_wrapper.cpp 0.00% 11 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #125      +/-   ##
========================================
+ Coverage   6.55%   8.33%   +1.78%     
========================================
  Files        136      67      -69     
  Lines      11053    8252    -2801     
  Branches     869     859      -10     
========================================
- Hits         724     688      -36     
+ Misses      9743    6980    -2763     
+ Partials     586     584       -2     
Flag Coverage Δ
differential 8.33% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mojomex mojomex self-requested a review March 11, 2024 12:18
@drwnz drwnz marked this pull request as ready for review March 14, 2024 10:37
Copy link
Collaborator

@mojomex mojomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mojomex mojomex merged commit 490069e into main Mar 14, 2024
7 checks passed
@mojomex mojomex deleted the feat/hesai_ptp_tsn_settings branch March 14, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants