-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hesai): add TSN settings for Hesai sensors (OT128) #125
Conversation
Signed-off-by: David Wong <[email protected]>
…P profile Signed-off-by: David Wong <[email protected]>
nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the comment above, the code looks good! Thank you.
I'll try and test it with a real sensor tomorrow.
nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: David Wong <[email protected]>
Signed-off-by: David Wong <[email protected]>
Signed-off-by: David Wong <[email protected]>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
========================================
+ Coverage 6.55% 8.33% +1.78%
========================================
Files 136 67 -69
Lines 11053 8252 -2801
Branches 869 859 -10
========================================
- Hits 724 688 -36
+ Misses 9743 6980 -2763
+ Partials 586 584 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR Type
Related Links
Description
Hesai OT128 has different handling of PTP settings, as it only allows 802.1AS Automotive and allows setting of switch type (TSN or not). This in turn changes PTP from the default P2P to use E2E when the switch type is changed to non-TSN.
Review Procedure
ptp_switch_type
toTSN
orNON_TSN
Remarks
ToDo:
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks