Fix spline collision point calculation #1136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of PR
Link to the issue
#1120
Description
I have fixed spline collision implementation error which caused spline to add normalized length to absolute lengths which is incorrect.
How to review this PR.
Others
Please note that in the
BuildAndRunworkflow the build was successful and only one test did not pass.This test does not pass because of the floating point numbers precision. The imperfection happens in a lambda I have added, specifically in line 159 in
hermite_curve.cpp.The length of the spline is calculated by interpolating it with 100 points which leads to minor errors.
I am in the process of improving
geometrytests and these test issues will be resolved.