Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new release flow #1185

Merged
merged 32 commits into from
Feb 14, 2024
Merged

Feature/new release flow #1185

merged 32 commits into from
Feb 14, 2024

Conversation

hakuturu583
Copy link
Collaborator

@hakuturu583 hakuturu583 commented Feb 1, 2024

Description

Abstract

  • Update Pull Request template.
  • Added github actions needed for the new release flow.
  • Immediately after this Pull Request is merged, the version will be version 1.0.0.

Background

The development team will require stricter version control in the future to ensure backward compatibility of the traffic_simulator API.
Accordingly, releases will be automated from now on, and will be done by labeling and instructing Pull Requests.

Details

After applying the new release flow, you can put one of the labels bump major, bump minor, or bump patch on the Pull Request, and when the Pull Request is merged with master, the version of scenario_simulator_v2 is bumped according to the label type.

The commit history after applying the new release flow is shown in the figure below.

Screenshot from 2024-02-05 12-10-07

In the new release flow, the master tracking confirmation of branches using merge queue and the determination of the executability of release actions will be added.

Inside the merge queue, the release action is only judged as executable, and the actual release work is executed on the master branch after merge.

GitHub Actions for release are controlled in parallel to avoid data conflicts.

Destructive Changes

This Pull Request only adds the GitHub Actions, templates, etc. necessary for the release, and there are no disruptive changes with respect to the C++ API, scenario format, etc.

However, the existing release flow will be fundamentally changed and semantic versions will not be compatible.

Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
@hakuturu583 hakuturu583 added the bump major If this pull request merged, bump major version of the scenario_simulator_v2 label Feb 1, 2024
@hakuturu583 hakuturu583 self-assigned this Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation is enough? If you think adding documents for this pull request, is unnecessary, please describe why and cross out this line.

Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
@hakuturu583 hakuturu583 marked this pull request as ready for review February 13, 2024 06:01
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
hakuturu583 and others added 9 commits February 14, 2024 15:54
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
@hakuturu583 hakuturu583 merged commit 5501254 into master Feb 14, 2024
11 checks passed
@hakuturu583 hakuturu583 deleted the feature/new_release_flow branch February 14, 2024 08:38
@github-actions github-actions bot restored the feature/new_release_flow branch February 14, 2024 08:39
@github-actions github-actions bot deleted the feature/new_release_flow branch February 14, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump major If this pull request merged, bump major version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants