Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update ament_auto_package macro #1363

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

Naophis
Copy link

@Naophis Naophis commented Sep 5, 2024

fix CONFIG_EXTRAS argument of ament_auto_package macro

(cherry picked from commit d9158d4)

Description

Please check examples and comment out this sentence. Minimal example is here and detailed example is here

Abstract

[Required] This section is required, keep it short, clear and to the point.
Delete this sentence and explain this pull request shortly.

Background

[Optional] If there is no background information that needs explanation (e.g., just a typo correction, etc.), you can skip this section.
Delete this sentence and explain the circumstances that led to this pull request being sent.

Details

[Optional] If there are only differences whose effects are so obvious that no explanation is needed, or if there are no differences in the code (e.g., documentation additions), you can skip this section.
Delete this sentence and describe this pull request.
For example, it is desirable to describe the specifications of added functions, and detailed explanations of bugs that have been fixed.

References

[Optional] If the referenced material does not exist, you can skip this section.
Describe any standards, algorithms, books, articles, etc. that you referenced when creating the pull request. If there is any novelty, mention it.

Destructive Changes

[Optional] If no destructive change exists, you can skip this section.
Include a description of the changes and a migration guide and send the pull request with a bump major label. (Example : #1139)
Otherwise, skip the "Destructive Changes" section and make sure this pull request is labeled bump minor or bump patch.

Known Limitations

[Optional] If there are no known limitations that you can think of, you can skip this section. If there are any limitations on the features or fixes added by this pull request, delete this sentence and clearly describe them.
For example, the lane matching algorithm currently (1/25/2024) employed is unable to match Entity that is heavily tilted with respect to the lane, and it is difficult to throw an exception.
If the developer is aware of the existence of such problems or limitations, describe them in detail. The problems or limitation should be listed as an Issue on GitHub and a link to it should be provided in this section.

fix CONFIG_EXTRAS argument of ament_auto_package macro

(cherry picked from commit d9158d4)
@Naophis Naophis merged commit 70cb25b into feat/maintain-0.9.0 Sep 5, 2024
6 of 7 checks passed
@Naophis Naophis deleted the fix/ament_auto_package_for_0.9.0 branch September 5, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants