-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RJD-1197/distance #1366
Merged
Merged
RJD-1197/distance #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into RJD-1197/distance
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
robomic
added
the
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
label
Sep 9, 2024
hakuturu583
requested changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems, you changed the behavior of the functions in traffic_simulator.
So, please run regression test before pull request open.
Regression tests: internal link |
hakuturu583
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
wait for regression test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
This PR contains unit tests for the distance namespace, which is a part of traffic_simulator package.
Additionally:
distanceToLeftLaneBound
anddistanceToRightLaneBound
.hdmap_utils
tests.intersection
was added. It contains a large, complex intersection and is convenient in numerous scenarios.Details
List of tests included in this PR:
References
Jira ticket: internal link
Destructive Changes
There are no destructive changes.
Regression tests
Jira comment: internal link