Reducing build time of openscenario_interpreter by utilizing precompiled headers
#1370
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
shouth
added
small feature
improvement
wait for regression test
bump patch
yamacir-kit
requested changes
Sep 25, 2024
Comment on lines
+39
to
+49
| "<nlohmann/json.hpp>" | ||
| "<rclcpp/rclcpp.hpp>" | ||
| "<traffic_simulator/api/api.hpp>" | ||
| "<pugixml.hpp>" | ||
|
|
||
| "<openscenario_interpreter/expression.hpp>" | ||
| "<openscenario_interpreter/object.hpp>" | ||
| "<openscenario_interpreter/pointer.hpp>" | ||
| "<openscenario_interpreter/record.hpp>" | ||
| "<openscenario_interpreter/scope.hpp>" | ||
| "<openscenario_interpreter/simulator_core.hpp>") |
There was a problem hiding this comment.
Please sort lexicographically, unless there is a technical reason why declaration order matters. Also, please remove blank lines.
|
I have confirmed that the openscenario_interpreter build is 3 minutes shorter in GitHub Actions as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
This pull request reduces the build time for
opendscenario_interpreterby using precompiled headers.Background
In the current codebase, large header files were being parsed multiple times and cause longer build time. To address this, I used Clang's
-ftime-traceto identify the headers that were taking the most time to parse and updatedCMakeLists.txtto ensure they are precompiled.Details
In my environment, the build time of
openscenario_interpreterwas reduced from 9m 21s to 7m 59s with 12 parallel builds.References
N/A
Destructive Changes
N/A
Known Limitations
N/A