Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /autoware/state to get autoware state #1378

Merged
merged 10 commits into from
Oct 9, 2024
Merged

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Sep 13, 2024

Description

Abstract

Changed back to using /autoware/state to get state of autoware(Includes support for the latest autoware_xx_msgs )

Background

Somehow autoware state API for has downgraded to old one in #1060.
Due to this change, the old spec, which mixed Autoware and Emergency states, are started to use, so emergency state which occurred immediately after engagement caused a time out.

Details

Regression risk analysis

Under autoware_auto_xx_msgs environment, we have used /autoware/state topic before #1060 and worked well.
and /autoware/state topic has maintained from after #1060 merged to today.
Starting from v0.29.0 in tier4/autoware.universe, /autoware/state uses autoware_system_msgs, which is being maintained and will continue to be supported in the future.

https://autowarefoundation.github.io/autoware.universe/main/system/autoware_default_adapi/document/autoware-state/

So, it is safe to use /autoware/state from the past to the future.

References

Regression test: OK (Note: X2 regression is expected)

Destructive Changes

None

Known Limitations

None

Copy link

github-actions bot commented Sep 13, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@HansRobo HansRobo added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Sep 13, 2024
@HansRobo HansRobo self-assigned this Sep 13, 2024
@HansRobo HansRobo changed the title Use /autoware/state in concealer Use /autoware/state to get autoware state Sep 13, 2024
@HansRobo HansRobo changed the title Use /autoware/state to get autoware state Use /autoware/state to get autoware state Sep 13, 2024
@HansRobo HansRobo marked this pull request as ready for review October 7, 2024 08:33
Copy link

sonarcloud bot commented Oct 9, 2024

@HansRobo HansRobo merged commit 457def3 into master Oct 9, 2024
12 checks passed
@HansRobo HansRobo deleted the feature/use-autoware-state branch October 9, 2024 08:17
@github-actions github-actions bot restored the feature/use-autoware-state branch October 9, 2024 08:18
@github-actions github-actions bot deleted the feature/use-autoware-state branch October 9, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants