-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use /autoware/state
to get autoware state
#1378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
HansRobo
added
the
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
label
Sep 13, 2024
HansRobo
changed the title
Use /autoware/state in concealer
Use /autoware/state to get autoware state
Sep 13, 2024
HansRobo
changed the title
Use /autoware/state to get autoware state
Use Sep 13, 2024
/autoware/state
to get autoware state
…erse>::autoware_state
…serDefinedValueCondition
Quality Gate passedIssues Measures |
yamacir-kit
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
wait for regression test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
Changed back to using
/autoware/state
to get state of autoware(Includes support for the latestautoware_xx_msgs
)Background
Somehow autoware state API for has downgraded to old one in #1060.
Due to this change, the old spec, which mixed Autoware and Emergency states, are started to use, so emergency state which occurred immediately after engagement caused a time out.
Details
Regression risk analysis
Under
autoware_auto_xx_msgs
environment, we have used/autoware/state
topic before #1060 and worked well.and
/autoware/state
topic has maintained from after #1060 merged to today.Starting from v0.29.0 in
tier4/autoware.universe
,/autoware/state
usesautoware_system_msgs
, which is being maintained and will continue to be supported in the future.https://autowarefoundation.github.io/autoware.universe/main/system/autoware_default_adapi/document/autoware-state/
So, it is safe to use
/autoware/state
from the past to the future.References
Regression test: OK (Note: X2 regression is expected)
Destructive Changes
None
Known Limitations
None