Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize API::getGoalPoses for goal modifications. #1385

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

TakanoTaiga
Copy link
Member

@TakanoTaiga TakanoTaiga commented Sep 17, 2024

Description

Abstract

⚠️This PR has been resubmitted due to a conflict with #1303. There are some changes included.
This pull request customizes the API::getGoalPoses function for goal modifications in Autoware.

Background

The goal position in Autoware is automatically modified by a feature called "goal modification." This PR addresses the need to retrieve the actual goal positions considering these modifications.

Details

The API::getGoalPoses function has been customized to check the goal field in /planning/mission_planning/route and retrieve the goal positions. When API::getGoalPoses is called for an Ego entity, this new logic is applied to extract the correct goal positions. Currently, VehicleEntity::getGoalPoses is being called, which only computes the route to the goal without considering the goal modifications.

References

https://github.com/tier4/sim_evaluation_tools/issues/351

Destructive Changes

N/A

Known Limitations

N/A

Copy link

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@TakanoTaiga TakanoTaiga self-assigned this Sep 17, 2024
@TakanoTaiga TakanoTaiga added the bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 label Sep 17, 2024
@TakanoTaiga TakanoTaiga marked this pull request as ready for review September 17, 2024 12:37
pyproject.toml Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 20, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants