Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Run SonarCloud scan step #1400

Closed
wants to merge 1 commit into from
Closed

Conversation

hakuturu583
Copy link
Collaborator

@hakuturu583 hakuturu583 commented Sep 27, 2024

Description

Abstract

add Run SonarCloud scan step in build and run workflow.

Background

I add SonarCloud setting file in #1398, but it in order to upload coverage, it needs GitHub Actions.

Details

Add official action for SonarCloud.

References

#1398

https://github.com/SonarSource/sonarcloud-github-action

Destructive Changes

N/A

Known Limitations

N/A

Signed-off-by: Masaya Kataoka <[email protected]>
@hakuturu583 hakuturu583 added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Sep 27, 2024
@hakuturu583 hakuturu583 self-assigned this Sep 27, 2024
Copy link

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@hakuturu583 hakuturu583 closed this Oct 7, 2024
@hakuturu583 hakuturu583 deleted the feature/sonar_cloud_scan branch October 7, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant