Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for cmake RelWithDebInfo build type #1405

Merged
merged 7 commits into from
Oct 3, 2024

Conversation

hakuturu583
Copy link
Collaborator

@hakuturu583 hakuturu583 commented Oct 2, 2024

Description

Abstract

Add Unit/Integration test for RelWithDebInfo build type.

Background

In #1402, I found that some of functions does not works valid in RelWithDebInfo build type.

Details

  • Add Unit/Integration test for RelWithDebInfo build type.
  • Use concurrency in GitHub Actions and specify cancel-in-progress = true

References

#1402

Destructive Changes

N/A

Known Limitations

Something wrong when you build with Debug build type.

Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
@hakuturu583 hakuturu583 added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Oct 2, 2024
@hakuturu583 hakuturu583 self-assigned this Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@hakuturu583 hakuturu583 closed this Oct 2, 2024
@hakuturu583 hakuturu583 deleted the test/cmake_flag_with_debug_and_relwithdebinfo branch October 2, 2024 07:23
@hakuturu583 hakuturu583 restored the test/cmake_flag_with_debug_and_relwithdebinfo branch October 2, 2024 07:33
@hakuturu583 hakuturu583 reopened this Oct 2, 2024
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
@hakuturu583 hakuturu583 changed the title Test/cmake flag with debug and relwithdebinfo Test/cmake flag with RelWithDebInfo Oct 3, 2024
@hakuturu583 hakuturu583 changed the title Test/cmake flag with RelWithDebInfo Test for cmake RelWithDebInfo build type Oct 3, 2024
@hakuturu583 hakuturu583 marked this pull request as ready for review October 3, 2024 01:16
Copy link
Member

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for green CIs.

@tier4 tier4 deleted a comment from github-actions bot Oct 3, 2024
@hakuturu583 hakuturu583 merged commit 8d2789c into master Oct 3, 2024
11 checks passed
@github-actions github-actions bot deleted the test/cmake_flag_with_debug_and_relwithdebinfo branch October 3, 2024 05:08
@HansRobo HansRobo linked an issue Nov 14, 2024 that may be closed by this pull request
@HansRobo HansRobo mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling error:
2 participants