-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for cmake RelWithDebInfo build type #1405
Merged
hakuturu583
merged 7 commits into
master
from
test/cmake_flag_with_debug_and_relwithdebinfo
Oct 3, 2024
Merged
Test for cmake RelWithDebInfo build type #1405
hakuturu583
merged 7 commits into
master
from
test/cmake_flag_with_debug_and_relwithdebinfo
Oct 3, 2024
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
hakuturu583
added
the
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
label
Oct 2, 2024
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
hakuturu583
changed the title
Test/cmake flag with debug and relwithdebinfo
Test/cmake flag with RelWithDebInfo
Oct 3, 2024
hakuturu583
changed the title
Test/cmake flag with RelWithDebInfo
Test for cmake RelWithDebInfo build type
Oct 3, 2024
HansRobo
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for green CIs.
github-actions
bot
deleted the
test/cmake_flag_with_debug_and_relwithdebinfo
branch
October 3, 2024 05:08
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
Add Unit/Integration test for
RelWithDebInfo
build type.Background
In #1402, I found that some of functions does not works valid in
RelWithDebInfo
build type.Details
RelWithDebInfo
build type.concurrency
in GitHub Actions and specifycancel-in-progress = true
References
#1402
Destructive Changes
N/A
Known Limitations
Something wrong when you build with
Debug
build type.