-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/joblist update traveled distance #1408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TakanoTaiga
added
the
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
label
Oct 2, 2024
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
TakanoTaiga
changed the title
Feature/jpblist update traveled distance
Feature/joblist update traveled distance
Oct 2, 2024
hakuturu583
requested changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is looks good to me.
Start regression test.
hakuturu583
approved these changes
Oct 7, 2024
github-actions
bot
deleted the
feature/jpblist-update-traveled-distance
branch
October 7, 2024 03:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
wait for regression test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
This pull request removes the
updateTraveledDistance
function from several entity classes. The function has been integrated into the job list management system for better cleaner code.Background
The
updateTraveledDistance
function was previously implemented in multiple entity classes. However, a more efficient and centralized method to track traveled distance through the job list system was introduced. This refactor eliminates redundant code and ensures consistency across different entity types.Details
The following changes were made:
updateTraveledDistance
function fromEntityBase
,EgoEntity
,PedestrianEntity
, andVehicleEntity
.EntityBase
using a new job that calculates the traveled distance based on linear velocity.updateTraveledDistance
as the functionality is now handled by the job system.References
N/A
Destructive Changes
N/A
Known Limitations
N/A