Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/joblist update traveled distance #1408

Merged
merged 7 commits into from
Oct 7, 2024

Conversation

TakanoTaiga
Copy link
Member

Description

Abstract

This pull request removes the updateTraveledDistance function from several entity classes. The function has been integrated into the job list management system for better cleaner code.

Background

The updateTraveledDistance function was previously implemented in multiple entity classes. However, a more efficient and centralized method to track traveled distance through the job list system was introduced. This refactor eliminates redundant code and ensures consistency across different entity types.

Details

The following changes were made:

  • Removed the updateTraveledDistance function from EntityBase, EgoEntity, PedestrianEntity, and VehicleEntity.
  • The traveled distance is now updated through the job list system in EntityBase using a new job that calculates the traveled distance based on linear velocity.
  • Updated unit tests by removing tests specifically for updateTraveledDistance as the functionality is now handled by the job system.

References

N/A

Destructive Changes

N/A

Known Limitations

N/A

@TakanoTaiga TakanoTaiga added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Oct 2, 2024
@TakanoTaiga TakanoTaiga self-assigned this Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@TakanoTaiga TakanoTaiga changed the title Feature/jpblist update traveled distance Feature/joblist update traveled distance Oct 2, 2024
@TakanoTaiga TakanoTaiga marked this pull request as ready for review October 3, 2024 12:25
Copy link
Collaborator

@hakuturu583 hakuturu583 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is looks good to me.
Start regression test.

@hakuturu583 hakuturu583 merged commit b01d613 into master Oct 7, 2024
11 checks passed
@github-actions github-actions bot deleted the feature/jpblist-update-traveled-distance branch October 7, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants