Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register StandStillDuration to job list #1409

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

TakanoTaiga
Copy link
Member

@TakanoTaiga TakanoTaiga commented Oct 2, 2024

Abstract

This pull request removes unused functions related to stand-still duration updates across multiple entities to optimize the codebase.

Background

The stand-still duration feature is being deprecated, so the related code is being removed to streamline maintenance and improve performance.

Details

  • Removed updateStandStillDuration function from EgoEntity, MiscObjectEntity, PedestrianEntity, and VehicleEntity classes.
  • Removed test cases related to the stand-still duration logic.
  • Updated job list registration in EntityBase to handle stand-still duration calculation within a job.

References

N/A

Destructive Changes

N/A

Known Limitations

N/A

@TakanoTaiga TakanoTaiga added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Oct 2, 2024
@TakanoTaiga TakanoTaiga self-assigned this Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@TakanoTaiga TakanoTaiga marked this pull request as ready for review October 3, 2024 12:25
Copy link
Collaborator

@hakuturu583 hakuturu583 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.
Start regression test.

Copy link
Collaborator

@hakuturu583 hakuturu583 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflict and re-run regression test.

@hakuturu583 hakuturu583 merged commit 7d2b703 into master Oct 10, 2024
16 checks passed
@github-actions github-actions bot deleted the feature/joblist-update-stand-still-duration branch October 10, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants