RJD-1335 Fix requestSpeedChange sets target_speed only when it's reached

[gmajrobotec]

Description

Abstract

The statement target_speed_ = target_speed.getAbsoluteValue(getCanonicalizedStatus(), other_status_); in firs example sets the target speed only in cases where the target speed has already been reached, which seems counter intuitive. This statement’s position is inconsistent with second example.

scenario_simulator_v2/simulation/traffic_simulator/src/entity/entity_base.cpp

Lines 471 to 480 in a7e29ef

	[this, target_speed](double) {
	if (other_status_.find(target_speed.reference_entity_name) == other_status_.end()) {
	return true;
	}
	if (isTargetSpeedReached(target_speed)) {
	target_speed_ = target_speed.getAbsoluteValue(getCanonicalizedStatus(), other_status_);
	return true;
	}
	return false;
	},

scenario_simulator_v2/simulation/traffic_simulator/src/entity/entity_base.cpp

Lines 458 to 464 in a7e29ef

	[this, target_speed](double) {
	if (other_status_.find(target_speed.reference_entity_name) == other_status_.end()) {
	return true;
	}
	target_speed_ = target_speed.getAbsoluteValue(getCanonicalizedStatus(), other_status_);
	return false;
	},

Details

Described statement is moved down, outside of the “if” statement. This way the most up to date target speed will be set on each iteration until the target speed is reached. This is consistent with continuous case.

References

Jira ticket: internal link

Destructive Changes

There are no destructive changes.

[github-actions]

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

• Is this pull request written in a way that is easy to read from a third-party perspective?
• Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
• If this pull request contains a destructive change, does this pull request contain the migration guide?
• Labels of this pull request are valid?
• All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
• The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.