Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve ValueError if there is no observed NavSatFix messages #175

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

ktro2828
Copy link
Contributor

@ktro2828 ktro2828 commented Dec 6, 2024

Description

This PR deals with the cases that NavSatFix message is not included in RosBag.

Before this PR, the following error has been raised in this case:

image

In order to deal with this problem, as of this PR, interpolation will be skipped and all geocoordinate fields will be filled by None as follows:

    [
       {
           "token": "922dd1d3795848398cd258ce6011969a",
           "translation": [
               6371.679376965268,
               14683.198967615801,
              -114.74298987091399
             ],
          "rotation": [
             -0.0011899695839468949,
              0.927482095564976,
              -0.3738644686696874,
              0.0009515488019675177
         ],
           "timestamp": 1724915739299722,
           "twist": [
               19.191881914181405,
               -0.32103013858398094,
               -0.285456699862336,
               0.9235548267151779,
               0.2642397397715217,
               0.32006239842098405
           ],
           "acceleration": [
               -0.3131694334716736,
                0.11359620433402622,
                -10.569883635372245
            ],
         "geocoordinate": null
  },

How to review

How to test

test data

TIER IV INTERNAL LINK

test command

python3 -mperception_dataset.convert --config config/convert_comlops_rosbag2_to_non_annotated_t4_sample.yaml

Reference

Notes for reviewer

@ktro2828 ktro2828 requested a review from miursh December 6, 2024 07:13
Copy link
Collaborator

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM

@miursh miursh merged commit bdb58fc into main Dec 9, 2024
5 checks passed
@miursh miursh deleted the fix/ins-handler branch December 9, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants