Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add FastLabel 3D to T4 format #183

Merged
merged 4 commits into from
Dec 21, 2024
Merged

Conversation

miursh
Copy link
Collaborator

@miursh miursh commented Dec 19, 2024

This pull request introduces a new conversion task to the perception_dataset module, adds new label configurations, and includes utility functions to handle rotations. The most important changes include adding a new converter class for FastLabel to T4 data, updating the conversion script to handle the new task, and enhancing the annotation loading and formatting functions.

New Converter Class:

Conversion Script Update:

  • perception_dataset/convert.py: Updated the main function to include a new task "convert_fastlabel_to_t4" that utilizes the FastLabelToT4Converter class.

Annotation Handling Enhancements:

Utility Functions for Rotations:

Label Configuration:

@miursh miursh requested a review from ktro2828 December 19, 2024 12:04
@miursh miursh changed the title feat: add FastLabel 3D to T4 feat: add FastLabel 3D to T4 format Dec 19, 2024
Signed-off-by: Shunsuke Miura <[email protected]>
Copy link
Contributor

@ktro2828 ktro2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miursh Thank you for your PR! Although I left one suggestion, the other parts look good.

@miursh miursh requested a review from ktro2828 December 20, 2024 18:37
Copy link
Contributor

@ktro2828 ktro2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh merged commit 4fbd27f into main Dec 21, 2024
5 checks passed
@miursh miursh deleted the feat/fastlabel/import_3d_label branch December 21, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants