Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add py.typed #195

Merged
merged 1 commit into from
Jan 29, 2025
Merged

feat: add py.typed #195

merged 1 commit into from
Jan 29, 2025

Conversation

tughril
Copy link
Contributor

@tughril tughril commented Jan 28, 2025

Description

In my project, I run type checking using mypy on CI for codes that depends on t4dataset_tools, but because py.typed does not exist in t4dataset_tools, the type checking does not work correctly.
As a workaround, py.typed is created at runtime, but I would like you to add it into t4dataset_tools.

How to review

How to test

test data

test command

Reference

Notes for reviewer

@tughril tughril requested a review from kminoda January 28, 2025 11:22
Copy link
Collaborator

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.
Could you please write the PR description in English?

Copy link
Collaborator

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tughril tughril merged commit 1634f14 into main Jan 29, 2025
5 checks passed
@tughril tughril deleted the feature/add_py_typed branch January 29, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants