Add tests for template variables #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @moorereason ! I'm sorry to bother you again, but could you please update this PR against master? I merged #48 and now test fails because dmarc.Parse signature changed. |
moorereason
force-pushed
the
feature-outputtests
branch
from
8c186fe
to
8cb08f0
Compare
Update tests since the data model changed after PR tierpod#48 was merged.
|
Thanks for fixes! I've faced with another unexpected problem - the tests on my PC failed because I have a different time zone than you. As a quick fix, I can suggest to change timezone in Makefile dmarc-report-converter/Makefile Line 19 in b9e6a84 I believe, there is a better way to deal with such test cases, but we (or I) can investigate this later. I tested with and tests passed |
Good catch. I should be able to fix this within the test in the next day or two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests to go with PR #47.