-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RS-2320] Doc for new support of Neutron QoS fields #1890
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
3ffaa9e
to
295bda4
Compare
Also: - remove extraneous final dashed lines, in some tables - remove inconsistent double-quoting of `openstack-region`
295bda4
to
fb6a184
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Currently, this is set for 3.30 only. Is that right? Are you ready for a merge?
@@ -68,7 +66,7 @@ node belongs to. | |||
|
|||
| Setting | Default Value | Meaning | | |||
| ------------------ | ------------- | ---------------------------------------------------------------------------- | | |||
| `openstack_region` | none | The name of the region that the local compute of controller node belongs to. | | |||
| openstack_region | none | The name of the region that the local compute of controller node belongs to. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. By rights, they all ought to be in code font
. But consistency is paramount.
Thanks @ctauchen . Yes, this is set for OSS 3.30, and does not apply to any previous versions. (Or to Enterprise or to Cloud.) |
Also:
openstack-region