Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RS-2320] Doc for new support of Neutron QoS fields #1890

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nelljerram
Copy link
Member

@nelljerram nelljerram commented Feb 10, 2025

Also:

  • remove extraneous final dashed lines, in some tables
  • remove inconsistent double-quoting of openstack-region

@nelljerram nelljerram requested a review from a team as a code owner February 10, 2025 11:39
Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit fb6a184
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/67a9e7afd7d77400081d8ea1
😎 Deploy Preview https://deploy-preview-1890--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit fb6a184
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/67a9e7afb6673400084ac7b5
😎 Deploy Preview https://deploy-preview-1890--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 28 (no change from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Also:
- remove extraneous final dashed lines, in some tables
- remove inconsistent double-quoting of `openstack-region`
Copy link
Collaborator

@ctauchen ctauchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Currently, this is set for 3.30 only. Is that right? Are you ready for a merge?

@@ -68,7 +66,7 @@ node belongs to.

| Setting | Default Value | Meaning |
| ------------------ | ------------- | ---------------------------------------------------------------------------- |
| `openstack_region` | none | The name of the region that the local compute of controller node belongs to. |
| openstack_region | none | The name of the region that the local compute of controller node belongs to. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. By rights, they all ought to be in code font. But consistency is paramount.

@nelljerram
Copy link
Member Author

Thanks @ctauchen . Yes, this is set for OSS 3.30, and does not apply to any previous versions. (Or to Enterprise or to Cloud.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants