Clean up network policies watches #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asincu
force-pushed
the
clean_up_watches
branch
2 times, most recently
from
1e663f7 to
1c77d76
Compare
asincu
force-pushed
the
clean_up_watches
branch
from
1c77d76 to
56356fa
Compare
| } | ||
|
|
||
| go utils.WaitToAddTierWatch(networkpolicy.TigeraComponentTierName, c, k8sClient, log, r.tierWatchReady) | ||
| go utils.WaitToAddNetworkPolicyWatches(c, k8sClient, log, []types.NamespacedName{ | ||
| {Name: linseed.PolicyName, Namespace: render.ElasticsearchNamespace}, |
There was a problem hiding this comment.
There are a few types of watches:
- Watches that are always in the Install namespace (helper.InstallNamespace())
- Watches that are always in the truth namespace (helper.TruthNamespace())
- Watches that are either in a specific namespace for single-tenant, and all namespaces for multi-tenant (like this one)
We actually define the helper above such that for multi-tenant clusters, helper.InstallNamespace returns "" so I think you can just use that here
caseydavenport
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove watches for network policies from elastic log storage controller and add them to sub-controllers that are responsible for rendering them.
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.