Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure manager to properly impersonate when communicating with managed clusters #3050

Merged

Conversation

caseydavenport
Copy link
Member

Description

tigera-manager needs to be configured with a tenant namespace so that it
can query managed clusters properly in a multi-tenant environment, and
to indicate that it should be using impersonation when talking to
managed clusters via Voltron.

In order to enable that flow, we must also grant
tigera-manager:tigera-manager permissions to "get" managed clusters
in order to pass Voltron's authorization checks.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@caseydavenport caseydavenport merged commit 669fd10 into tigera:master Dec 9, 2023
3 checks passed
@caseydavenport caseydavenport deleted the casey-manager-impersonate branch December 9, 2023 00:23
@danudey danudey modified the milestones: v1.33.0, v1.34.0 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants