Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EV-4381 Add linseedDeployment in Tenant CR #3051

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

vara2504
Copy link
Contributor

@vara2504 vara2504 commented Dec 9, 2023

linseedDeployment is used to configure resource request and limit per tenant

vara@vara:~/bzprofiles/Clusters/tc_mt$ k get deployment.apps/tigera-linseed -n tenant-a -o yaml |grep -A 5 "resources"
        resources: {}
        securityContext:
          allowPrivilegeEscalation: false
          capabilities:
            drop:
            - ALL
vara@vara:~/bzprofiles/Clusters/tc_mt$ kubectl patch tenant default -n tenant-a --type=merge --patch='{"spec": {"linseedDeployment": {"spec": {"template": {"spec": {"containers":[{"name":"tigera-linseed","resources":{"limits":{"cpu":"1", "memory":"512Mi"}}}]}}}}}}'
tenant.operator.tigera.io/default patched
vara@vara:~/bzprofiles/Clusters/tc_mt$ k get deployment.apps/tigera-linseed -n tenant-a -o yaml |grep -A 5 "resources"
        resources:
          limits:
            cpu: "1"
            memory: 512Mi
        securityContext:
          allowPrivilegeEscalation: false

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very small nit, but otherwise this LGTM

Expect(d.Spec.Template.Spec.Containers[0].Name).To(Equal("tigera-linseed"))
Expect(d.Spec.Template.Spec.Containers[0].Resources).To(Equal(linseedResources))
})
It("should Override initcontainer's resource request with the value from TenantSpec's linseedDeployment when available and CertificateManagement is enabled", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should be a newline before this "It()"

linseedDeployment is used to configure resource request and limit per tenant
@caseydavenport caseydavenport merged commit d02d73e into tigera:master Dec 13, 2023
3 checks passed
@danudey danudey modified the milestones: v1.33.0, v1.34.0 Jan 31, 2024
asincu pushed a commit to asincu/operator that referenced this pull request Feb 23, 2024
linseedDeployment is used to configure resource request and limit per tenant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants