Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add design / code guidelines document #3057

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Add design / code guidelines document #3057

merged 1 commit into from
Dec 13, 2023

Conversation

caseydavenport
Copy link
Member

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@caseydavenport caseydavenport requested a review from a team as a code owner December 12, 2023 18:10
@marvin-tigera marvin-tigera added this to the v1.33.0 milestone Dec 12, 2023
@caseydavenport caseydavenport merged commit ddeed95 into tigera:master Dec 13, 2023
3 checks passed
@caseydavenport caseydavenport deleted the casey-guidelines branch December 13, 2023 20:51
@danudey danudey modified the milestones: v1.33.0, v1.34.0 Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electricjesus electricjesus electricjesus approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
v1.34.0
Development

Successfully merging this pull request may close these issues.
4 participants
@caseydavenport @electricjesus @danudey @marvin-tigera