Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] fix: missing logging arguments for dikastes #3058

Conversation

electricjesus
Copy link
Member

Description

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@electricjesus electricjesus requested a review from a team as a code owner December 13, 2023 10:23
@marvin-tigera marvin-tigera added this to the v1.33.0 milestone Dec 13, 2023
@electricjesus electricjesus changed the base branch from master to release-v1.33 December 13, 2023 12:09
@caseydavenport
Copy link
Member

Not sure what's going on with CI, but it's failing for some reason.

@electricjesus electricjesus reopened this Dec 13, 2023
@electricjesus electricjesus changed the title fix: missing logging arguments for dikastes [cherry-pick] fix: missing logging arguments for dikastes Dec 13, 2023
@electricjesus electricjesus merged commit dcb6175 into tigera:release-v1.33 Dec 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants