-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show support for current Nova version #206
Conversation
@marcusmoore Is there anything else you think should be added? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I have some minor questions/changes but overall 👍🏾
Thank you 😄
Fixed in next commit Co-authored-by: Marcus Moore <[email protected]>
…ackages into show-nova-version
@marcusmoore I can also close #63 with the same type of tag instead of saying |
@RhysLees thanks for the updates and also peeking at additional issues that might be solved in a similar manner. A separate PR would be appreciated. I'll review (and hopefully merge) this PR later this week. Thanks again! 😄 |
Awesome, thanks for Reviewing, I'll wait until this is merged then I'll make a PR for the other issue as it mainly uses the same code from this PR 😊 |
@RhysLees hey look at that! This has been deployed. Thank you for your work on this 😄 |
AYYYYYYY let's go! Thanks for your help in making it possible! |
This PR adds the following:
nova_version to packages DB Table
Nova version to PackageDetailFrame if their latest stable release requires a Nova version
Current Nova Version Supported Label to Package cards if their latest stable release requires a Nova version that matches the major version specified in env
Adds Nova's current filter to tags and filters their latest stable release if it requires a Nova version that matches the major version specified in env
When a new major version of Nova is released all that is needed is to increase the version in .env from
NOVA_LATEST_MAJOR_VERSION=4
toNOVA_LATEST_MAJOR_VERSION=5
Closes #196