Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show support for current Nova version #206

Merged
merged 14 commits into from
May 6, 2022
Merged

Show support for current Nova version #206

merged 14 commits into from
May 6, 2022

Conversation

RhysLees
Copy link
Contributor

@RhysLees RhysLees commented Apr 22, 2022

This PR adds the following:

  • nova_version to packages DB Table

  • Nova version to PackageDetailFrame if their latest stable release requires a Nova version
    image

  • Current Nova Version Supported Label to Package cards if their latest stable release requires a Nova version that matches the major version specified in env
    image

  • Adds Nova's current filter to tags and filters their latest stable release if it requires a Nova version that matches the major version specified in env
    image

When a new major version of Nova is released all that is needed is to increase the version in .env from NOVA_LATEST_MAJOR_VERSION=4 to NOVA_LATEST_MAJOR_VERSION=5

Closes #196

@RhysLees
Copy link
Contributor Author

@marcusmoore Is there anything else you think should be added?

Copy link
Contributor

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I have some minor questions/changes but overall 👍🏾

Thank you 😄

app/Jobs/SyncPackagePackagistData.php Outdated Show resolved Hide resolved
app/Jobs/SyncPackagePackagistData.php Outdated Show resolved Hide resolved
config/novapackages.php Show resolved Hide resolved
config/novapackages.php Show resolved Hide resolved
app/Jobs/SyncPackagePackagistData.php Show resolved Hide resolved
app/Jobs/SyncPackagePackagistData.php Outdated Show resolved Hide resolved
@RhysLees
Copy link
Contributor Author

RhysLees commented Apr 29, 2022

@marcusmoore I can also close #63 with the same type of tag instead of saying Potentially Abandoned Would it be worth adding to this PR or as a separate PR?

image

@RhysLees RhysLees requested a review from marcusmoore April 29, 2022 15:36
@marcusmoore
Copy link
Contributor

@RhysLees thanks for the updates and also peeking at additional issues that might be solved in a similar manner. A separate PR would be appreciated.

I'll review (and hopefully merge) this PR later this week.

Thanks again! 😄

@RhysLees
Copy link
Contributor Author

RhysLees commented May 3, 2022

@RhysLees thanks for the updates and also peeking at additional issues that might be solved in a similar manner. A separate PR would be appreciated.

I'll review (and hopefully merge) this PR later this week.

Thanks again! 😄

Awesome, thanks for Reviewing, I'll wait until this is merged then I'll make a PR for the other issue as it mainly uses the same code from this PR 😊

@marcusmoore marcusmoore merged commit 25a8dee into tighten:main May 6, 2022
@marcusmoore
Copy link
Contributor

@RhysLees hey look at that!

CleanShot 2022-05-06 at 10 49 29

This has been deployed. Thank you for your work on this 😄

@RhysLees
Copy link
Contributor Author

RhysLees commented May 6, 2022

@RhysLees hey look at that!

CleanShot 2022-05-06 at 10 49 29

This has been deployed. Thank you for your work on this 😄

AYYYYYYY let's go! Thanks for your help in making it possible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show support for Nova version 3 or 4
3 participants