Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the List of Takeout Containers #182

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

danielebarbaro
Copy link
Contributor

@danielebarbaro danielebarbaro commented Nov 10, 2020

Changed

  • Extracts the base and full aliases from the takeout list command and put those behind an optional --networking flag

@danielebarbaro
Copy link
Contributor Author

danielebarbaro commented Dec 9, 2020

Hi, now list command have --networking option.
Screenshot 2020-12-09 at 10 03 27

Here an output example:

Screenshot 2020-12-09 at 10 02 39

--json option is done on #149 .

Do we need a network command to listtakeout network?

Screenshot 2020-12-09 at 10 18 34

@danielebarbaro danielebarbaro marked this pull request as ready for review December 9, 2020 09:08
@mattstauffer
Copy link
Member

Do we need a network command to list takeout network?

Would there be any particular value in that?

@mattstauffer
Copy link
Member

taking a look now!

app/Shell/Docker.php Outdated Show resolved Hide resolved
@mattstauffer
Copy link
Member

OK, looks good to me with the one suggestion fixed!

@tonysm tonysm changed the title [WIP] - Add networking option on list command. Simplify the List of Takeout Containers Dec 18, 2024
@tonysm tonysm requested a review from mattstauffer December 18, 2024 22:17
app/Shell/Docker.php Show resolved Hide resolved
app/Commands/ListCommand.php Show resolved Hide resolved
@danielebarbaro
Copy link
Contributor Author

Hey folks, I’ve always been a big fan of you and Tighten—basically a groupie here! While I wait for the day Matt can sign my Laravel up&running books, I’m always up for collaborating on this project, even if this PR is from 4 years ago. Feel free to reach out to me for any future developments too! 🤓

@tonysm
Copy link
Contributor

tonysm commented Dec 18, 2024

@danielebarbaro thanks for the work on this! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants