Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Install #326

Merged
merged 27 commits into from
Dec 16, 2024
Merged

Docker Install #326

merged 27 commits into from
Dec 16, 2024

Conversation

tonysm
Copy link
Contributor

@tonysm tonysm commented Oct 27, 2023

Added

  • Adds a Dockerfile for the dockerized install of Takeout
  • Adds a docker-publish.yml workflow that builds and pushes the Docker image whenever there's a new tag

Changed

  • Updates the install instructions to mention the new approach

@tonysm tonysm marked this pull request as ready for review November 3, 2023 14:33
…can detect within takeout itself, if needed)
@tonysm tonysm mentioned this pull request Nov 4, 2023
Copy link
Contributor

@gcavanunez gcavanunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on windows and macos - things running smoothly 🚀

@tonysm tonysm force-pushed the tm/docker-install branch from 7107bd6 to 060a03a Compare December 7, 2024 01:00
Copy link
Member

@driftingly driftingly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just a few suggestions on making some updates after this has sat for so long.

Let's do this! :)

.github/workflows/docker-publish.yml Outdated Show resolved Hide resolved
.github/workflows/docker-publish.yml Outdated Show resolved Hide resolved
.github/workflows/docker-publish.yml Outdated Show resolved Hide resolved
.github/workflows/docker-publish.yml Outdated Show resolved Hide resolved
.github/workflows/docker-publish.yml Outdated Show resolved Hide resolved
@@ -0,0 +1,18 @@
FROM php:8.1-cli-alpine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to being able to bump this 🙌

README.md Outdated

To update the image, run `docker pull tighten/takeout` when you want to get the newest release.

Otherwise, if you have a PHP environment available, you may install Takeout via Composer:

```bash
composer global require "tightenco/takeout:~2.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we be bumping to 3.0 with this release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm, maybe we can tag a 2.9 now, and then switch to 3.0 once we upgrade it to the major PHP version?

README.md Outdated Show resolved Hide resolved
tonysm and others added 2 commits December 9, 2024 10:52
@tonysm tonysm merged commit 57228d2 into main Dec 16, 2024
11 checks passed
@tonysm tonysm deleted the tm/docker-install branch December 16, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants