Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a takeout shell command #349

Merged
merged 12 commits into from
Dec 6, 2024
Merged

Add a takeout shell command #349

merged 12 commits into from
Dec 6, 2024

Conversation

tonysm
Copy link
Contributor

@tonysm tonysm commented Sep 20, 2024 •
edited
Loading

Added

  • Adds a takeout shell {service} command to get a shell inside any container started with Takeout
  • Fixes the CouchDB not starting. Looks like we now need to pass a user and password config
  • Fixes the EventStoreDB. The flags that were passed no longer work
  • Fixes OpenSearch not starting, the security plugin should be disabled by default

closes #348

@tonysm tonysm requested a review from mattstauffer September 20, 2024 22:05
@tonysm
Copy link
Contributor Author

tonysm commented Sep 20, 2024

I've tested it with all the supported containers.

gcavanunez
gcavanunez approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@gcavanunez gcavanunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

mattstauffer
mattstauffer requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@mattstauffer mattstauffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! Just a few quick notes :)

app/Services/BaseService.php Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tonysm tonysm requested a review from mattstauffer October 4, 2024 16:50
@tonysm
Copy link
Contributor Author

tonysm commented Oct 4, 2024

@mattstauffer ready for review again!

@tonysm tonysm merged commit fbc9a3d into main Dec 6, 2024
11 checks passed
@tonysm tonysm deleted the tm/shell-cmd branch December 6, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcavanunez gcavanunez gcavanunez approved these changes

@mattstauffer mattstauffer mattstauffer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a takeout shell command
3 participants
@tonysm @mattstauffer @gcavanunez